[PATCH] staging: speakup: rename enum constant CT_Off

Samuel Thibault samuel.thibault at ens-lyon.org
Wed Jul 25 15:41:19 EDT 2018


Arnabjyoti Kalita, le mer. 25 juil. 2018 15:39:38 -0400, a ecrit:
> checkpatch.pl generates the following warning.
> 
> CHECK: Avoid CamelCase: <CT_Off>
> 
> CT_Off is written in CamelCase notation which is not allowed as 
> per the preferred coding style in the Linux kernel and hence 
> appears as a warning by checkpatch. Rename CT_Off to CT_OFF so 
> that it is no longer in CamelCase notation.
> 
> Signed-off-by: Arnabjyoti Kalita <arnabjyotikalita35 at gmail.com>
> ---
>  drivers/staging/speakup/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 869f40e..7824aa3 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -95,7 +95,7 @@ static int cursor_track = 1, prev_cursor_track = 1;
>  
>  /* cursor track modes, must be ordered same as cursor_msgs */
>  enum {
> -	CT_Off = 0,
> +	CT_OFF = 0,
>  	CT_On,

Err, please do make all others all upper case too.

Samuel


More information about the Speakup mailing list