Buggy speakup on Ubuntu 12.04?

[Samuel Thibault]

Hello,

Chris Brannon, le Sat 16 Jun 2012 08:48:42 -0500, a écrit :
> "Bohdan R. Rau" <ethanak at polip.com> writes:
> 
> > 1) if I press "go to" key, any next key causes immediately kernel panic
> 
> Hey Bohdan,
> I think I found the source of the goto bug.
> If you look at the handle_goto function from main.c of the Speakup
> sources,  you'll see this declaration:
> 
> static u_char *goto_buf = "\0\0\0\0\0\0";
> 
> That just creates a pointer to a string constant.
> Try to assign to *goto_buf, and boom, there is your panic.
> 
> Instead, we want:
> 
> static u_char goto_buf[] = "\0\0\0\0\0\0";

Indeed, and as commented, no need to explicitly initialize to zeros
since it's a static buffer.

Could you handle submitting the fix to the linux-kernel mailing list?

Samuel