speakupconf problem and fix

Adam Myrow myrowa at bellsouth.net
Mon Jun 22 21:25:59 EDT 2009


Hi.  I just updated Speakup with GIT to check out some of the changes.  I 
found a problem with speakupconf right off.  It was failing to save 
parameters because it was giving the "find" command invalid options.  A 
little investigation showed that the problem was in this line of code.

SAVELIST=`find . -readable -writable -type f |sed 's/..//'`

The problem is, the version of find in Slackware 12.2 does not recognize 
the "-readable" and "-writable" options.  I suspect that they are in some 
newer version of find.  The "find --version" command gives the following 
on my system.

GNU find version 4.2.31
Built using GNU gnulib version 2007-02-24
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION

I quickly found the solution.  I modified the problem line to look like 
this.

SAVELIST=`find . -perm -u+rw -type f |sed 's/..//'`

I believe this accomplishes the same thing as the original line, using the 
"-perm" flag which is a part of find on just about any Unix system in 
existence.  Does anybody see any problem with having this change made to 
the GIT version of speakupconf?  It is probably best to use the most 
portable syntax where possible to avoid future problems like this. 
Thanks.




More information about the Speakup mailing list