[PATCH] staging: speakup: refactor synths array to use a list

[Keith Barrett]

On 16/10/18 01:24, Gregory Nowak wrote:
> Just wanted to say I documented this issue on Okash's speakup issues
> page:
> <http://www.github.com/bytefire/speakup/issues/7>
> 
> Greg
> 
Right, there is something very odd going on here regarding loading the 
modules.

I have an appollo connected to the serial port.

There is an entry in /etc/modprobe.d/local.conf loading speakup_soft.
However, on booting the system, speakup_apollo is loaded and the apollo 
works but I cannot work out how that module is being loaded.




> 
> On Tue, Oct 09, 2018 at 02:56:14PM +0100, Keith Barrett wrote:
>>
>>
>> On 18/06/18 06:34, Gregory Nowak wrote:
>>> On Tue, Jun 12, 2018 at 08:31:06AM +0200, Samuel Thibault wrote:
>>>> The load/unload is about the module itself, i.e. modprobe speakup_bns ;
>>>> modprobe speakup_soft, switch between them, then rmmod speakup_bns ;
>>>> speakup_soft or the converse (to exercise both orders).
>>>
>>> # uname -a
>>> Linux p41box 4.17.1 #1 SMP Sat Jun 16 11:19:57 MST 2018 i686 GNU/Linux
>>> # lsmod |grep "speakup"
>>> speakup_bns            16384  0
>>> speakup_soft           16384  1
>>> speakup                94208  3 speakup_bns,speakup_soft
>>>
>>> With /sys/accessibility/speakup/synth set to bns, I am getting output
>>> alternately from the bns and from soft. It's as if speakup can't make
>>> up its mind which synthesizer is being used. When I echo soft
>>>> /sys/accessibility/speakup/synth, I get no speech at all from either
>>> synthesizer. Doing rmmod of all three speakup modules comes back with
>>> no errors. There is also no unusual output in dmesg, I can see both
>>> synthesizers being registered and unregistered as I switch between
>>> them.
>>>
>>> I can also reproduce this behavior with speakup_soft, and speakup_dummy
>>> specifically:
>> Also the same with speakup_soft and speakup_apollo on debian buster updated
>> as of 9th October 2018.
>>
>>>
>>> 1. modprobe speakup_soft and modprobe speakup_dummy
>>>
>>> 2. The synthesizer should now be set to dummy in
>>>     /sys/accessibility/speakup/synth.
>>>
>>> 3. Use the speakup review keys, press enter a number of times. You
>>>     should observe output from both the software speech, and from the
>>>     serial port alternating between each other.
>>>
>>> 4. echo soft >/sys/accessibility/speakup/synth
>>>
>>> 5. You should observe no output from either software speech or the
>>>     serial port as you use speakup review keys, or press enter
>>>     repeatedly.
>>>
>>> 6. echo dummy >/sys/accessibility/speakup/synth
>>>
>>> 7. You should alternately get speech from the software synthesizer and
>>>     from the serial port.
>>>
>>> I built my kernel from the 4.17.1 kernel.org sources, and the patch
>>> that Samuel reposted applied cleanly with no errors.
>>>
>>> Greg
>>>
>>>
>>
>