Fix mutex lock/unlock

Samuel Thibault samuel.thibault at ens-lyon.org
Thu May 3 15:39:12 EDT 2018


Hello William,

While looking at the speakup source code I noticed a missing
mutex_lock/unlock pair, please see the attached patch.

Samuel
-------------- next part --------------
signal: Add missing mutex_lock/unlock around the while loop

---
 signal.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/signal.c
+++ b/signal.c
@@ -63,7 +63,9 @@ void *signal_thread(void *arg)
 			printf("espeakup caught signal %d\n", sig);
 			break;
 		}
+		pthread_mutex_lock(&queue_guard);
 	}
+	pthread_mutex_unlock(&queue_guard);
 	/* Tell the reader to stop, if it is in a select() call. */
 	write(PIPE_WRITE_FD, STOP_MSG, strlen(STOP_MSG));
 	return NULL;


More information about the Speakup mailing list