speakup-r functionality

John Covici covici at ccs.covici.com
Mon May 29 08:08:45 EDT 2017


OK, I will test as soon as I can.

On Mon, 29 May 2017 05:50:33 -0400,
Okash Khawaja wrote:
> 
> On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote:
> > I just have one question -- how did it work with the old serial i/o
> > system?
> In main.c, handle_cursor_read_all calls spk_get_index_count which calls
> spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or
> old serial i/o is in use. So the difference is in spk_serial_in_nowait
> as the layers above that are identical. spk_serial_in_nowait returns 0
> when there is no data on rx. spk_ttyio_in_nowait immitates that but due
> to the signedness bug, it was returning 0xff instead of 0 when there
> is no data.
> 
> With the fix, now both serial i/o and TTY stacks  should have same
> behaviour.

-- 
Your life is like a penny.  You're going to lose it.  The question is:
How do
you spend it?

         John Covici
         covici at ccs.covici.com


More information about the Speakup mailing list