[PATCH] staging: speakup: fix warning for static declaration

Okash Khawaja okash.khawaja at gmail.com
Mon Mar 27 04:39:37 EDT 2017

On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> > Thanks for this :) Could you also move the function higher in the same
> > file - above line 139 where all static functions are defined?
> I'd say no need for this. spk_serial_in is just above.  Moving functions
> just for the sake of static vs non-static does not make the code more
> readable to my eyes :)
> (and it makes tracking changes harder in git annotate)
> Samuel

Fair enough. When I marked it as static and moved it higher, I
misinterpreted your comment as we neither want it static nor moved. You
probably meant the latter :)

More information about the Speakup mailing list