[PATCH] staging: speakup: fix warning for static declaration

Samuel Thibault samuel.thibault at ens-lyon.org
Mon Mar 27 03:55:57 EDT 2017


Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva at embeddedor.com>

Yes, indeed.

Reviewed-by: Samuel Thibault <samuel.thibault at ens-lyon.org>

Thanks

> ---
>  drivers/staging/speakup/serialio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 5e31aca..3fab1c3 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
>  }
>  EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
>  
> -int spk_serial_out(struct spk_synth *in_synth, const char ch)
> +static int spk_serial_out(struct spk_synth *in_synth, const char ch)
>  {
>  	if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
>  		outb_p(ch, speakup_info.port_tts);
> -- 
> 2.5.0
> 

-- 
Samuel
 Je suis maintenant possesseur d'un ordinateur portable Compaq Armada
 1592DT avec port infra-rouge. Auriez-vous connaissance de programmes
 suceptibles d'utiliser ce port afin de servir de télécommande ?
 -+- JN in NPC : ben quoi, c'est pas à ça que ça sert ?


More information about the Speakup mailing list