[patch 6/6] staging: speakup: Migrate acntsa, bns, dectlk and txprt to ttyio
okash.khawaja at gmail.com
Fri Mar 24 15:40:42 EDT 2017
On Fri, Mar 24, 2017 at 08:24:22PM +0100, Samuel Thibault wrote:
> Okash Khawaja, on ven. 24 mars 2017 19:21:54 +0000, wrote:
> > On Sun, Feb 26, 2017 at 03:59:30AM +0100, Samuel Thibault wrote:
> > > and then in speakup_apollo.c, instead of
> > >
> > > outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR);
> > > outb(UART_MCR_DTR | UART_MCR_RTS,
> > > speakup_info.port_tts + UART_MCR);
> > Is there a specific reason for keeping DTR set all the time? Or is it
> > just a defensive measure?
> I guess the device requires it. That's normal RS232 signaling anyway.
> With tiocmset, however, you won't have to care: the generic code will
> already have enabled DTR, and you will only want to clear and set RTS.
I noticed that spk_serial_init sets it and other places keep it set. By
generic code, do you mean that when migrated to TTY, we don't have to
explicitly set DTR?
More information about the Speakup