[patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c

Okash Khawaja okash.khawaja at gmail.com
Thu Mar 16 02:51:54 EDT 2017

On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > serialio.c. These functions do outgoing serial comms. The move is a step
> > towards collecting all serial comms in serialio.c. This also renames
> > spk_synth_immediate to spk_serial_synth_immediate.
> > 
> > Code inside those functions has not been changed. Along the way, this patch
> > also fixes a couple of spots which were calling spk_synth_immediate directly,
> > so that the calls now happen via the spk_syth struct.
> > 
> > Signed-off-by: Okash Khawaja <okash.khawaja at gmail.com>
> > Reviewed-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
> > 
> > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
> This patch doesn't apply to my tree at all.  The first 3 applied with
> some fuzz, so I think you are not working against linux-next. Please
> rebase your patch against linux-next, or my staging-testing branch, and
> resend so I can apply it.

Sure, will rebase against staging-testing. Just this patch or the
patch set?

More information about the Speakup mailing list