[patch 3/7] staging: serial: add spk_io_ops struct to spk_synth
samuel.thibault at ens-lyon.org
Sun Mar 12 08:04:01 EDT 2017
Okash Khawaja, on dim. 12 mars 2017 11:52:02 +0000, wrote:
> On Sun, Mar 12, 2017 at 11:33:32AM +0100, Samuel Thibault wrote:
> > Okash Khawaja, on dim. 12 mars 2017 09:32:25 +0000, wrote:
> > > > Don't unnecessarily move the code, only drop the export symbol.
> > >
> > > Since spk_serial_out is not more exported, I made it static and moved it
> > > closer to other static functions which are all towards the top of the
> > > file.
> > There is no need for this :)
> Ah I see, utlimately we plan to completely replace serialio with ttyio.
Well, serialio might remain for some time, but anyway shuffling code
around in a sensitive patch series doesn't help getting it accepted :)
More information about the Speakup