[PATCH] staging: speakup: make function ser_to_dev static

Okash Khawaja okash.khawaja at gmail.com
Wed Jun 28 16:29:58 EDT 2017


Hi,

On Wed, Jun 28, 2017 at 02:13:51PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> The helper function ser_to_dev does not need to be in global scope, so
> make it static.
> 
> Cleans up sparse warning:
> "warning: symbol 'ser_to_dev' was not declared. Should it be static?"
Thanks very much!

> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Reviewed-by: Okash Khawaja <okash.khawaja at gmail.com>

> ---
>  drivers/staging/speakup/spk_ttyio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index 442f191a017e..ed8e96b06ead 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -21,7 +21,7 @@ struct spk_ldisc_data {
>  static struct spk_synth *spk_ttyio_synth;
>  static struct tty_struct *speakup_tty;
>  
> -int ser_to_dev(int ser, dev_t *dev_no)
> +static int ser_to_dev(int ser, dev_t *dev_no)
>  {
>  	if (ser < 0 || ser > (255 - 64)) {
>  		pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n");
> -- 
> 2.11.0
> 


More information about the Speakup mailing list