Line discipline

Samuel Thibault samuel.thibault at ens-lyon.org
Sat Jan 28 12:57:09 EST 2017


Okash Khawaja, on Sat 28 Jan 2017 17:49:01 +0000, wrote:
> Added tty_ldisc_release() which resolved the problem.

Ok, good.

> Also added tty_ldisc_flush() before tty_ldisc_release().

I don't think it's really needed since the user is asking for speakup to
go away anyway, but it shouldn't hurt.

> Wouldn't it be safer to add those functions before tty_unlock()?

See callers of these, they don't lock the tty.

> The only output I get from speakup_dummy is:
> 
> Speakup
> RATE 8
> PITCH 8
> VOL 8
> TONE 8
> Dummy found

But are you working on the linux text console?

Samuel


More information about the Speakup mailing list