[patch 3/6] staging: speakup: refactor spk_stop_serial_interrupt

[Samuel Thibault]

Okash Khawaja, on dim. 26 févr. 2017 15:11:54 +0000, wrote:
> > On 25 Feb 2017, at 23:03, Samuel Thibault <samuel.thibault at ens-lyon.org> wrote:
> >
> > Okash Khawaja, on sam. 25 févr. 2017 19:25:26 +0000, wrote:
> >> This moves call to spk_stop_serial_interrupt() function out of synth_release()
> >> and into release() method of specific spk_synth instances.
> >
> > Did you try to compile this as a module?  It seems this is missing an
> > EXPORT_SYMBOL_GPL line for modules to be able to call it.
> 
> It should need EXPORT_SYMBOL_GPL for other synths to compile as
> modules

Yes.

> but I don't get a linker warning when compiling them as modules. Am I
> missing something here?

I don't know, perhaps some config option about modules.

What I'm sure of is that it's needed at least for some configurations :)

Samuel