[PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt

Samuel Thibault samuel.thibault at ens-lyon.org
Wed Feb 8 18:04:37 EST 2017


Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote:
> This moves the call to spk_stop_serial_interrupt() function into
> release() method of respective synths.

Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.

Samuel


More information about the Speakup mailing list