[patch] staging: speakup: fix speakup-r empty line lockup

Samuel Thibault samuel.thibault at ens-lyon.org
Mon Aug 28 16:17:23 EDT 2017


Hello,

Okash Khawaja, on sam. 26 août 2017 18:15:13 +0100, wrote:
> +static volatile int in_keyboard_notifier = 0;

Why "volatile"? Is the read from read_all_doc really done by another
thread?

The presence of volatile is usually very bad sign: either there is
proper synchronization, and volatile is useless, or there isn't, and
volatile just makes code work by luck sometimes only (even if that means
"most of the time", that's not "all the time" :) )

Samuel


More information about the Speakup mailing list