[PATCH v2 0/4] staging: speakup: refactor to make room for serial comms changes

[Okash Khawaja]

> On 21 Nov 2016, at 10:05, Greg KH <gregkh at linuxfoundation.org> wrote:
> 
>> On Sat, Nov 19, 2016 at 11:03:28PM +0100, Samuel Thibault wrote:
>> Hello,
>> 
>> Just looking over the patch, it looks good. I don't think it needs to be
>> split in 4 pieces though, I'd say merge patches 1, 3, and 4 together,
>> where patch 3 would be modified to make dummy use spk_serial_out too, to
>> get a patch which does just one complete thing: make serial_out a
>> method.
>> 
>> Then you'll have other patches introducing spk_serial_out_tty and making
>> some drivers use it.
>> 
>> Also note that as Greg said, the patches you have just submitted do
>> not really make sense alone.  I don't know if staging people feel like
>> applying them while it's only pavement for future work.  If so, then
>> good; otherwise, then fine too: it's good that you have sent them so
>> that we could check how they look like, I just wanted to let you know
>> that they might not get applied yet, just because one may want to see
>> the future patches before applying what you have done so far.
> 
> I would like to see the full patch series that uses these changes as
> right now these patches do nothing on their own, so I don't want to
> apply them.
> 
> thanks,
> 
> greg k-h

Sure, will send complete patch set. 
Thanks,
Okash