commit breaks speakup serial support
Brandon McGinty-Carroll
bmmcginty at bmcginty.us
Sat Sep 12 20:37:34 EDT 2015
I'm refreshing the source to check, but I know speakup code has gone to driverdev-devel in the past.
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Brandon
On Tue, Sep 08, 2015 at 06:16:00AM -0400, covici at ccs.covici.com wrote:
> Hi. I have found a commit in the 3.17-3.18 kernel tree which totally
> breaks speakup's serial support because someone blindly used check.pl
> and followed its advise without using their brains.
>
> The commit is f79b0d9c223ca09cefffc72304a7bcbc401a1c6f and here is the
> diff for that.
> diff --git a/drivers/staging/speakup/serialio.h
> b/drivers/staging/speakup/serialio.h
> index 0a93773..317bb84 100644
> --- a/drivers/staging/speakup/serialio.h
> +++ b/drivers/staging/speakup/serialio.h
> @@ -4,7 +4,7 @@
> #include <linux/serial.h> /* for rs_table, serial constants */
> #include <linux/serial_reg.h> /* for more serial constants */
> #ifndef __sparc__
> -#include <asm/serial.h>
> +#include <linux/serial.h>
> #endif
>
> /*
>
> As you can see this breaks serialio.c, so it can't find the serial port
> -- so how do I get the devs to ax this commit?
>
> Thanks.
>
> --
> Your life is like a penny. You're going to lose it. The question is:
> How do
> you spend it?
>
> John Covici
> covici at ccs.covici.com
> _______________________________________________
> Speakup mailing list
> Speakup at linux-speakup.org
> http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
More information about the Speakup
mailing list