patch to make speakup-r work in recent kernels

covici at ccs.covici.com covici at ccs.covici.com
Thu May 21 01:44:55 EDT 2015


speakup-r is a function which allows continuous reading of a document
and when you stop reading, the  cursor is where you left off.  This
stopped working in kernel 3.6 because of this commit
4369c64c79a22b98d3b7eff9d089196cd878a10a is the first bad commit
commit 4369c64c79a22b98d3b7eff9d089196cd878a10a
Author: Henrik Rydberg <rydberg at euromail.se>
Date:   Sat Sep 15 15:23:35 2012 +0200

    Input: Send events one packet at a time

    On heavy event loads, such as a multitouch driver, the irqsoff latency
    can be as high as 250 us.  By accumulating a frame worth of data
    before passing it on, the latency can be dramatically reduced.  As a
    side effect, the special EV_SYN handling can be removed, since the
    frame is now atomic.

    This patch adds the events() handler callback and uses it if it
    exists. The latency is improved by 50 us even without the callback.

    Cc: Daniel Kurtz <djkurtz at chromium.org>
    Tested-by: Benjamin Tissoires <benjamin.tissoires at enac.fr>
    Tested-by: Ping Cheng <pingc at wacom.com>
    Tested-by: Sedat Dilek <sedat.dilek at gmail.com>
    Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
    Signed-off-by: Henrik Rydberg <rydberg at euromail.se>

:040000 040000 9ff0ae120a6a0c5f81678f60c020136ca3b4f56f 2708951fb2572ebe91f70115632bd85ad5fdce09 M      drivers
:040000 040000 c9c7f25822de01c00809d4a99def341495ce1b0a eab83ca81d51bb2b5227c0de47bffe81378b577c M      include

The problem was that the fakekey.c routine to fake a down arrow no
longer functioned properly and putting the input_sync fixed it.

I hope that helps.

Greg Kroah-Hartman <gregkh at linuxfoundation.org> wrote:

> On Wed, May 20, 2015 at 05:44:11AM -0400, covici at ccs.covici.com wrote:
> > Here is a patch to make speakup-r work on recent kernels.
> > Acked-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
> > Signed-off-by: John Covici <covici at ccs.covici.com>
> 
> Can you provide a changelog that says why this is needed and what it
> does?  "make it work" just isn't all that descriptive, sorry.
> 
> And what is "recent kernels"?  When did this break?  What broke?
> 
> thanks,
> 
> greg k-h

-- 
Your life is like a penny.  You're going to lose it.  The question is:
How do
you spend it?

         John Covici
         covici at ccs.covici.com


More information about the Speakup mailing list