[PATCH v2 3/4] staging: speakup: reuse native hex2bin()

[Samuel Thibault]

Andy Shevchenko, le Thu 28 Mar 2013 11:02:45 +0200, a écrit :
> -		} else if (*p1 == 'x' &&
> -				strchr(hx, p1[1]) && strchr(hx, p1[2])) {
...
> -		} else
> -			*p++ = *p1++;
> +		} else {
> +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
...
> +			} else
> +				*p++ = *p1++;
> +		}

Why not keeping the same else if structure?  It looks nicer to me to
keep a series of else if.

> +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {

Count should be 2, shouldn't it?

Samuel